[wp-trac] [WordPress Trac] #50233: Limit pagination for comments

[WordPress Trac]

#50233: Limit pagination for comments
-------------------------------------------------+-------------------------
 Reporter:  devrekli                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Permalinks                           |     Version:  5.4.1
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by costdev):

 * keywords:  has-patch has-unit-tests => has-patch has-unit-tests needs-
     testing


Comment:

 Patch
 [https://core.trac.wordpress.org/attachment/ticket/50233/50233.4.diff
 50233.4.diff] adds these changes to `src/wp-includes/link-template.php`.
 This makes the unit test pass.

 However, this raises the following questions:
 1. Is `wp_get_canonical_url()` the correct method to use in the existing
 unit test?
   - If not, the correct method should be determined and the unit test
 corrected.

 2. Does the failing patch work with manual testing?

 3. Does the attached patch work with manual testing?

 4. Does the attached patch work without the changes to `src/wp-
 includes/canonical.php`?
   - If not:
     - Both `src/wp-includes/canonical.php` and `src/wp-includes/link-
 template.php` need to be patched.
     - More tests are needed to properly test the changes in `src/wp-
 includes/canonical.php`.

 Adding `needs-testing` so this can be picked up by the Test team.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50233#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform