[wp-trac] [WordPress Trac] #46371: Make sure in-page anchors are not hidden behind top bars

[WordPress Trac]

#46371: Make sure in-page anchors are not hidden behind top bars
---------------------------------------+-----------------------------------
 Reporter:  afercia                    |       Owner:  sabernhardt
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  5.9
Component:  Toolbar                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui, accessibility,
                                       |  css
---------------------------------------+-----------------------------------
Changes (by costdev):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch


Comment:

 == Test Report
 === TL;DR
 Patch works as expected on all four testing scenarios provided.

 === Env
 * WordPress 5.9-alpha-20211116.134713
 * Chrome 95.0.4638.69
 * Windows 10
 * Theme: Twenty Twenty
 * Gutenberg Editor
 * Plugin: None activated
 === Steps to test
 See [https://core.trac.wordpress.org/ticket/46371#comment:21 this comment
 above].

 === Before patch
 1. In-page anchor: The heading is partially hidden by the admin toolbar.
 2. Continue Reading link: The content is partially hidden by the admin
 toolbar.
 3. Skip to content on frontend: The content is partially hidden by the
 admin toolbar.
 4. Skip to main content in admin: The content is partially hidden by the
 admin toolbar. (this was supposed to be fine before the patch, according
 to the testing instructions).

 === After patch
 1. In-page anchor: The heading appears below the admin toolbar and is
 fully visible.
 2. Continue Reading link: The content appears below the admin toolbar and
 is fully visible.
 3. Skip to content on frontend: The content appears below the admin
 toolbar and is fully visible.
 4. Skip to main content in admin: The content appears below the admin
 toolbar and is fully visible.

 === Comments
 * Very nice work on resolving this issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46371#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform