[wp-trac] [WordPress Trac] #52622: Fix PHP Warning on PHP7.2 in class-wp-http-curl.php

[WordPress Trac]

#52622: Fix PHP Warning on PHP7.2 in class-wp-http-curl.php
-------------------------------------+-------------------------------------
 Reporter:  sjoerdlinders            |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.9
Component:  HTTP API                 |     Version:  5.6.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-unit-    |     Focuses:  administration,
  tests php8                         |  coding-standards
-------------------------------------+-------------------------------------

Comment (by jrf):

 I've only had a quick look, but I think punting this to WP 6.0 would be
 the better choice.
 1. It's very late in the day for WP 5.9.
 2. It looks like the class is making direct Curl requests instead of using
 the Requests library.
 3. No tests, so no safeguard we're not breaking something.

 Does sound like a good ticket to have a more in-depth discussion about,
 possibly in the livestream @hellofromTonya and me do regularly ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52622#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform