[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
-------------------------+---------------------
 Reporter:  jameskoster  |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.9
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:
-------------------------+---------------------

Comment (by andraganescu):

 Investigated this a bit.

 The Customizer has the site icon functionality as a control, but not a
 standalone one unfortunately: it is a special case of the cropped image
 control, which is itself a special case of the image control.

 Reusing that implementation in the settings page is nearly impossible as
 we suffer from the "bananna -> gorilla holding the bananna -> entire
 jungle" problem. The UI is also wired to the customizer in terms of
 interactivity and CSS.

 The settings admin section is quite lean. To replicate how setting the
 site icon behaves a new cropping and preview functionality should be
 added, which is a lot for one thing, which already exists in the
 Customizer for classic themes. I have not investigated thorroughly enough
 to see if there is some simple approach that I miss, but implementing a
 good UX will add quite a lot of stuff to the general settings part.

 Therefore this ticket, IMO, is not just duplicating a feature, but instead
 a new implementation for a new context of this site icon feature. I
 believe that to make the most of it we should implement it keeping in mind
 how to turn this later in whatever Gutenberg will need for its settings
 panel, so maybe a REST site icon thing is good to have.

 Given the above, this would be more worth it if - and I doubt it - these
 admin settings forms will not be later superseeded by Site Editor settings
 panels and other related functionality. Otherwise it is a temporary
 solution **in terms of usefulness**, with ''potentially'' a lot of stuff
 required to be crammed in.

 I agree with @jameskoster 's view that we shoult not ''remove'' settings
 because the site editor can set them. But to duplicate settings because
 the site editor can't set them ''yet'' is a different thing in my mind.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform