[wp-trac] [WordPress Trac] #54420: Tests: Mock REST API remote requests
WordPress Trac
noreply at wordpress.org
Thu Nov 11 19:21:09 UTC 2021
#54420: Tests: Mock REST API remote requests
------------------------------+-----------------------------
Reporter: hellofromTonya | Owner: hellofromTonya
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 6.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: rest-api
------------------------------+-----------------------------
Comment (by hellofromTonya):
Replying to [comment:10 SergeyBiryukov]:
> Thanks for the ticket and the fixes!
>
> Just noting that [52137] addresses the failure in `test_get_items()`,
but not in `test_get_items_no_results()`, which also
[https://github.com/WordPress/wordpress-
develop/runs/4174016666?check_suite_focus=true#step:20:250 failed in the
same job] and apparently needs a similar fix.
>
> Should we move the `pre_http_request` filter into a helper method to be
reused there?
Whoops, missed that one. Thanks for the ping @SergeyBiryukov. To keep it
simply, I agree with adding a helper method. Doing it now.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54420#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list