[wp-trac] [WordPress Trac] #42979: Draw "dismiss" icon in upload errors in the error div, not after the action title

[WordPress Trac]

#42979: Draw "dismiss" icon in upload errors in the error div, not after the action
title
--------------------------+------------------------------------------------
 Reporter:  ComputerGuru  |       Owner:  joedolson
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.9
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility, administration
  needs-testing           |
--------------------------+------------------------------------------------
Changes (by joedolson):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 Placing the dismiss button inside the error div only makes sense if we're
 also going to implement separate dismiss buttons for each individual
 error. I agree that it's not really beneficial to dismiss each error
 individually, so this is a simplest case.

  - Changes to a text button, using the existing screen-reader-text.
  - Moves the button to the bottom of the status container.
  - Updates CSS to remove dashicon & position button.

 To test:

  - upload one or more disallowed file types in the media library grid & in
 the media library modal
  - Check positioning and text of dismiss button
  - Verify screen reader behavior. (Read errors, then button text, focus
 button)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42979#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform