[wp-trac] [WordPress Trac] #54336: Add Global Styles REST API endpoints from Gutenberg plugin into Core
WordPress Trac
noreply at wordpress.org
Wed Nov 10 14:27:17 UTC 2021
#54336: Add Global Styles REST API endpoints from Gutenberg plugin into Core
--------------------------------------+-------------------------------
Reporter: noisysocks | Owner: jorgefilipecosta
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 5.9
Component: REST API | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-------------------------------
Comment (by desrosj):
I wanted to raise a few concerns I have about some of the method names and
phrasing within `WP_Theme_JSON_Resolver`.
- The `get_user_*()` functions are a bit misleading. In reading their
names, it's reasonable to assume that they are retrieving user specific
data. But that's not true. A few ocblocks also reference the "user's
origin configuration", but it does not have anything to do with users in
the WordPress sense.
- A handful of functions refer to a custom post type. Anything built into
WordPress Core is not really custom. Could these be changed to "site
global styles" or "get current global styles"?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54336#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list