[wp-trac] [WordPress Trac] #54385: Fatal error uploading media on PHP8

[WordPress Trac]

#54385: Fatal error uploading media on PHP8
--------------------------+------------------------------
 Reporter:  stevegs       |       Owner:  adamsilverstein
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.9
Component:  Media         |     Version:  2.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by adamsilverstein):

 > I'll do a quick search of the plugin repo

 Reviewing current usage by plugins, the most popular ones (from this
 search: https://wpdirectory.net/search/01FM2JG73C9T9369YKYXJE6SNR)
 actually use it the exact way core does, meaning they round the results
 directly and will break under PHP 8 unless we cast the response.

 @TobiasBg Indeed, casting the return might be better. I'll update the
 patch to work that way instead as you suggestive.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54385#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform