[wp-trac] [WordPress Trac] #53988: remove duplicate code in wp_list_filter()
WordPress Trac
noreply at wordpress.org
Mon Nov 8 17:23:57 UTC 2021
#53988: remove duplicate code in wp_list_filter()
------------------------------+-----------------------------
Reporter: pbearne | Owner: hellofromTonya
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 5.9
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+-----------------------------
Changes (by hellofromTonya):
* keywords: has-patch => has-patch commit
* owner: (none) => hellofromTonya
* status: new => reviewing
Comment:
In reviewing and testing [attachment:"53988.diff"], @SergeyBiryukov I
think you did resolve an issue. Bailing out without resetting the
`$output` property to an empty array means `WP_List_Util::get_output()`
may not be in the right state when invoked. This was why the tests were
failing.
The patch looks good to me. Marking it for `commit`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53988#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list