[wp-trac] [WordPress Trac] #54370: Add an option to configure the site icon in general settings

[WordPress Trac]

#54370: Add an option to configure the site icon in general settings
-------------------------------------------------+-------------------------
 Reporter:  jameskoster                          |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-patch 2nd-opinion needs-       |     Focuses:
  design-feedback                                |
-------------------------------------------------+-------------------------
Changes (by andraganescu):

 * keywords:  needs-patch => needs-patch 2nd-opinion needs-design-feedback


Comment:

 Am I totally wrong in thinking
 [https://github.com/WordPress/gutenberg/pull/35892 the PR] should be
 enough? For now block themes can only set site icon to be the same with
 site logo. That is really not so bad.

 By adding a stop gap solution, IMO we just seem to create more cruft:

 - Will the site icon setting in settings remain for classic themes or
 would it only appear if there is a block theme active?
 - Either way it's not great that we're _adding_ things for temporary
 reasons.
 - If we add it, and it works for both classic and block themes, we'd have
 ''yet another thing which can be achieve in two places''.
 - If we add it, and it works for block themes only, it will be confusing
 when a user saw it there and then it's gone.

 Also what will happen to this setting once we do have the option to set it
 in the site editor? I assume it will remain and continue to set the site
 icon. But at that time we'd have three different implementations of code
 that sets the site icon: customizer (works only for classic themes),
 options page (works for both kinds of themes) and site editor settings
 page (works only for block themes). The setting itself however is shared
 across theme kinds, only the interface to set it wildly changes based on
 context.

 So I say let's not add this setting to settings. It should have been added
 when it was coded in the customizer. Now however, seems to me we're just
 adding, as I said, cruft.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54370#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform