[wp-trac] [WordPress Trac] #54392: Core themes need to display required text field information

[WordPress Trac]

#54392: Core themes need to display required text field information
---------------------------------------+--------------------------------
 Reporter:  joedolson                  |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.9
Component:  Bundled Theme              |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  required-fields has-patch  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------
Changes (by sabernhardt):

 * keywords:  needs-patch required-fields => required-fields has-patch


Comment:

 The `logged_in_as` text has been `null` since the initial commits for both
 [https://github.com/WordPress/twentynineteen/blob/be850d11ee31434ad700db518ff8570f82e65b9c/inc
 /template-tags.php#L277 Twenty Nineteen] and
 [https://github.com/WordPress/twentytwentyone/blob/956a3172a41545ca04a133c034b47ae870a4a9cd/comments.php#L74
 Twenty Twenty-One], so I do not know the reasoning behind that choice.

 The simplest way to fix the missing required fields message is to undo
 that removal.

 If we change it to the required fields text only, however, the custom
 message argument could get rather messy here. Even if I want to use
 exactly the same text as the core default argument now includes, that
 seems to require (copying and) re-writing the markup within the context of
 the theme. Something like the functions proposed in #54394 might help in
 that situation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54392#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform