[wp-trac] [WordPress Trac] #17636: Search subtitles are handled inconsistently across admin
WordPress Trac
noreply at wordpress.org
Tue Nov 2 15:56:22 UTC 2021
#17636: Search subtitles are handled inconsistently across admin
----------------------------------------------+----------------------------
Reporter: kawauso | Owner:
| johnjamesjacoby
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.9
Component: Comments | Version: 3.2
Severity: normal | Resolution: fixed
Keywords: has-patch commit has-screenshots | Focuses:
| administration
----------------------------------------------+----------------------------
Changes (by johnjamesjacoby):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"51975" 51975]:
{{{
#!CommitTicketReference repository="" revision="51975"
Admin/Comments: remove bespoke truncation from search string HTML.
This change removes a call to `wp_html_excerpt()` used on the HTML output
of the search string, supplied by the current user in the previous page
request via the named `s` input in the search-box UI.
If the search string is extremely long, it wraps around the available
empty space in a way that is not visually displeasing, confirming that
truncation is not a requirement here.
This also addresses a small accessibility concern as the non-truncated
string was not alternatively presented, and helps normalize the output of
`$_REQUEST['s']` for more broad improvements in the future.
Props hareesh-pillai, jakubtyrcha, johnjamesjacoby, lukecavanagh,
sabernhardt.
Fixes #17636.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/17636#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list