[wp-trac] [WordPress Trac] #51278: Update return types to reflect the real return types. Remove mixed.

[WordPress Trac]

#51278: Update return types to reflect the real return types. Remove mixed.
------------------------------------+-------------------------------------
 Reporter:  ReneHermi               |       Owner:  (none)
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  Future Release
Component:  General                 |     Version:
 Severity:  major                   |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  docs, coding-standards
------------------------------------+-------------------------------------
Changes (by ReneHermi):

 * severity:  normal => major


Comment:

 It's an important update to the docs. The lack of getting someone to
 review this quickly proves the necessity of why this docBlock update is so
 important. The one who reviews this might think she will have to go
 through a line-by-line check of `get_option()` because it does have so
 many exceptions instead of clear return values. I'd say it's not necessary
 to do this and this PR can be added into the core without such a deep code
 inspection.

 Very talented people have already looked into this like @johnbillion

 Even if we overlooked something in this PR (which I do not believe) it
 will still improve the documentation tremendously with less effort. At
 worse it will not cover and document all eventualities and return values
 but the current docBlock only covers a fraction of them.

 So instead of refining and delaying this PR more and more until so much
 time has passed that it is not going to be anywhere, I highly recommend
 bringing it into core asap. Then we can still fine-tune it with smaller
 PR's which are easier to review if it should be necessary.

 I've changed severe status from normal to major and hope someone will get
 on to this soon. We are nearing 10 months for such a "simple" PR. I do not
 expect someone to look into this if it takes more time.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51278#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform