[wp-trac] [WordPress Trac] #51549: Update to phpass 0.5

[WordPress Trac]

#51549: Update to phpass 0.5
--------------------------------+------------------------
 Reporter:  ayeshrajans         |       Owner:  desrosj
     Type:  enhancement         |      Status:  reviewing
 Priority:  normal              |   Milestone:  5.8
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch commit    |     Focuses:
--------------------------------+------------------------
Changes (by desrosj):

 * keywords:  has-patch 2nd-opinion => has-patch commit
 * status:  assigned => reviewing


Comment:

 I've discussed with some other members of the security team, and this one
 seems like a fine update.

 [attachment:"51549.diff"] is the same as @ayeshrajans's patch with one
 exception. I removed the inline comments for the two constructor functions
 to bring the WordPress copy of the library more inline with the upstream
 version. When that adjustment was made to Core, the PHP 5 type constructor
 was not included in the upstream library. Now that it is, I think it makes
 more sense to remove it in favor of consistency.

 Only the last two modifications in your list above should now be relevant.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51549#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform