[wp-trac] [WordPress Trac] #52429: Combine/globalize the CSS/JS between Site Health & Privacy Settings
WordPress Trac
noreply at wordpress.org
Tue May 25 17:49:02 UTC 2021
#52429: Combine/globalize the CSS/JS between Site Health & Privacy Settings
-------------------------+---------------------------------------
Reporter: xkon | Owner: notlaura
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.8
Component: Site Health | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, css, privacy
-------------------------+---------------------------------------
Comment (by ryelle):
I think the only case where this would remove styles from plugins is if
they're using `site-health` on the frontend, or have intentionally un-
enqueued `wp-admin`. I think the latter is unlikely. Do you think anyone's
using `site-health` on the frontend? I looked through a few of the results
from the search and they seem to be wp-admin pages, so this makes no
change.
The PR is looking good, the issues I flagged have been fixed ✅
> What tool are you using to generate these diffs? Is that related to
#49606, or something you are doing locally?
It's local, I have a framework for [https://github.com/ryelle/grab-
screenshots grabbing screenshots with puppeteer] and I've been writing
little scripts for each ticket I review, then using the `npm run diff`
command (in that project) to run [https://www.npmjs.com/package/blink-diff
blink-diff] over them. (I keep meaning to write a blog post about this 😅
)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52429#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list