[wp-trac] [WordPress Trac] #52353: Comments list's link should point to an actual article

[WordPress Trac]

#52353: Comments list's link should point to an actual article
-----------------------------+-----------------------------
 Reporter:  trejder          |       Owner:  SergeyBiryukov
     Type:  enhancement      |      Status:  reviewing
 Priority:  normal           |   Milestone:  5.8
Component:  Comments         |     Version:  5.7
 Severity:  normal           |  Resolution:
 Keywords:  has-screenshots  |     Focuses:  administration
-----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-screenshots needs-refresh => has-screenshots


Comment:

 Replying to [comment:16 Hareesh Pillai]:
 > In the attached patch, I believe
 >
 > {{{
 > <br /><a href="%s">%s</a>
 > }}}
 >
 > should be
 >
 > {{{
 > <br /><a href="%1$s">%2$s</a>
 > }}}

 Thanks! Just noting that using numbered placeholders in practice only
 matters for translatable strings (so that translators could change the
 order where it makes sense to do so), otherwise there is roughly the same
 amount of both `<a href="%1$s">%2$s</a>` and `<a href="%s">%s</a>`
 instances in core. That said, there is a line using numbered placeholders
 right above, so that would indeed be more consistent.

 Replying to [comment:11 trejder]:
 > The design look great. Thank you. My only concern is, if "View [post
 type]" shouldn't be force-placed in second line, i.e. directly under
 "Comments on" (as proposed in initial report of this feature)?
 >
 > Because in certain scenarios (certain screen resolution, certain post's
 title length) it might break in the middle of this two-word phase (3+
 word, if post type has a long name) and produce not quite very good
 looking feeling of having "View" in first line (directly after title) and
 "[post type]" in second line.

 Thanks! I went back and forth about including a line break as suggested in
 [attachment:"52353.3.diff"], but I think it looks better with the "View
 Post" link next to the title. To address the concern of keeping the link
 on one line, we can use the existing `.comments-view-item-link` CSS class,
 which adds `display: inline-block`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52353#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform