[wp-trac] [WordPress Trac] #52625: Test tool and unit test improvements for 5.8
WordPress Trac
noreply at wordpress.org
Tue May 25 01:07:57 UTC 2021
#52625: Test tool and unit test improvements for 5.8
--------------------------------------+---------------------
Reporter: desrosj | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 5.8
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+---------------------
Comment (by SergeyBiryukov):
In [changeset:"50986" 50986]:
{{{
#!CommitTicketReference repository="" revision="50986"
Tests: Minimize the chances of signature conflicts for
`assertEqualsWithDelta()`.
The PHPUnit 7.5+ method `assertEqualsWithDelta()` was polyfilled for
PHPUnit < 7.5, but also overloaded for PHPUnit 7.5 itself, which was not
necessary and created a higher chance of signature conflicts, especially
when the WP test suite is used as a basis for integration tests with
plugins/themes.
This change removes the unnecessary overloading for PHPUnit 7.5+ and
simplifies the overloaded method for PHPUnit < 7.5, including removing the
`IsEqual()` class alias declaration, no longer needed.
Follow-up to [48952].
Props jrf.
See #52625.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52625#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list