[wp-trac] [WordPress Trac] #30240: Tell if theme is a child theme in wp-admin/network/themes.php

[WordPress Trac]

#30240: Tell if theme is a child theme in wp-admin/network/themes.php
-------------------------------------+-------------------------------------
 Reporter:  dpik                     |       Owner:  SergeyBiryukov
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.8
Component:  Themes                   |     Version:  4.0
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-ui-   |     Focuses:  administration,
  feedback has-patch                 |  multisite
-------------------------------------+-------------------------------------

Comment (by SergeyBiryukov):

 Thanks for the patch!

 Just noting that `esc_attr()` or `esc_url()` are not needed here, because
 `WP_Theme::display()` already applies the appropriate escaping via the
 `WP_Theme::markup_header()` method, and that is how these values are
 displayed elsewhere in the file. There is also no point in translating
 strings like `__( '%s' )`, it can just be printed directly.

 Replying to [comment:30 joyously]:
 > This ticket was originally for the Network Themes list, but I think it
 makes sense to be consistent and indicate that a theme is a child theme
 everywhere it is listed.
 >
 > I suggest that the same method be used on the Network Themes list and on
 the normal Themes page, as shown in comment 16: The word "Child" is first,
 linked to the local copy of the parent theme, followed by the child theme
 name. And it also makes sense to make the Details view show a link to the
 parent theme, instead of just the name.

 I agree it would be great to aim for a consistent indication, however I
 wonder if that is feasible with the several different parts of the themes
 UI that we have (outlined in comment:36:ticket:48491). Specifically, the
 theme details modal and the Network Themes list table look quite different
 and have different UI elements. I also wonder if linking the word "Child"
 to the parent theme is clear enough and not confusing in terms of
 accessibility.

 So I would like to go back to the original focus of the ticket on Network
 Themes screen.

 Looking at the current patch though, it includes a link to the parent
 theme's URI instead of a local link to the parent theme details modal. I
 wonder if the latter would be more helpful, however that is something the
 current implementation in that same modal does not have, as seen in
 [attachment:"Screenshot 2014-11-04 00.59.59.png"].

 So I would suggest going with a simpler patch here, along the lines of
 [attachment:"30240.2.patch"], which would look like
 [attachment:"30420-patched.png"]. That seems consistent enough to me for
 now :)

 If someone feels strongly about making the parent theme name a link to the
 theme's URI or theme details modal, or making any other changes to unify
 the parent theme indication in various places, please create a new ticket.
 Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/30240#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform