[wp-trac] [WordPress Trac] #30969: adding theme support for 'custom-header' or 'custom-background' results to duplicate admin menu items
WordPress Trac
noreply at wordpress.org
Sat May 22 19:51:04 UTC 2021
#30969: adding theme support for 'custom-header' or 'custom-background' results
to duplicate admin menu items
--------------------------+------------------------------
Reporter: edville101 | Owner: (none)
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: 4.1
Severity: normal | Resolution:
Keywords: 2nd-opinion | Focuses: administration
--------------------------+------------------------------
Changes (by celloexpressions):
* milestone: => Awaiting Review
Comment:
The history here is that these pages were kept for compatibility for users
with JavaScript disabled when we deprecated the pages in favor of the
customizer. The JS runs in the browser on load to hide the menu items with
CSS. If they don't get hidden, it's actually probably because there's a JS
error somewhere. There are several places sprinkled throughout wp-admin
where similar logic applies for showing customizer links.
`hide-if-customize` is essentially used as `hide-if-has-js`. The customize
user capability is mapped to edit-theme-options by default, so users with
access to the header and background should have access to the customizer
also.
At this point, can lose all of that logic and remove the links entirely?
How many pages in wp-admin work at all with JS disabled?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/30969#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list