[wp-trac] [WordPress Trac] #30009: _wp_put_post_revision checks for errors incorrectly

WordPress Trac noreply at wordpress.org
Fri May 21 19:49:42 UTC 2021


#30009: _wp_put_post_revision checks for errors incorrectly
---------------------------------------------+-----------------------------
 Reporter:  rmccue                           |       Owner:  SergeyBiryukov
     Type:  defect (bug)                     |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.8
Component:  Revisions                        |     Version:  2.6
 Severity:  minor                            |  Resolution:
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+-----------------------------
Changes (by adamsilverstein):

 * keywords:  has-patch dev-feedback => has-patch has-unit-tests commit


Comment:

 @SergeyBiryukov I added a test and am running all tests in
 https://github.com/WordPress/wordpress-develop/pull/1279.

 If everything looks good, this is ready for commit. Before this fix
 `is_wp_error` on line 274 would never pass!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/30009#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list