[wp-trac] [WordPress Trac] #21603: Add ability to delete multiple menu items

[WordPress Trac]

#21603: Add ability to delete multiple menu items
-------------------------------------+-------------------------------------
 Reporter:  wphound                  |       Owner:  audrasjb
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.8
Component:  Menus                    |     Version:  3.4.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch needs-testing needs-design-  |  javascript, administration
  feedback                           |
-------------------------------------+-------------------------------------
Changes (by joedolson):

 * keywords:  has-screenshots has-patch needs-testing => has-screenshots
     has-patch needs-testing needs-design-feedback


Comment:

 This works pretty well! A few more comments:

 1) Using a checkbox that is masked to look like a button can be confusing.
 For most users, it'll be fine, but if you're sighted & using a keyboard,
 it looks like a toggle button - but when you hit 'Enter' to toggle the
 button, it'll submit the form. I think you should leave the checkbox
 visible, so the usage is clear. This would also be more similar to the
 interfaced for bulk select used in post tables.

 2) The list of selected items works, and reads out. I think, to eliminate
 ambiguity, it might be good if it also include the menu type. E.g. 'Test
 3, Page. Test 4, Custom Link'. For complex menus, this might be helpful.
 But it's not absolutely critical - definitely open to other opinions.

 3) After deleting items, the announcement of items deleted is read, so
 that's great. But the the 'List of items to be deleted' is read again,
 which is confusing.

 4) For internationalization, arrange the test sent to wp.a11y.speak as
 `Deleted: "item 1", "item2"`. This helps make the strings not dependent on
 tenses and cases of the items deleted. E.g. 'Hello World! have been
 deleted' doesn't make a lot of sense.

 5) Suggest also using 'Deleted menu item' instead of 'Deleted', just to
 give an extra confirmation that the item itself wasn't deleted.

 6) There are some stray spaces in the strings. E.g., 'List of menu items
 selected for deletion :' (extra space before colon)

 That's a lot of feedback, I know, but this is looking pretty good,
 functionality-wise. I'm adding 'needs-design-feedback' to get some design
 feedback on the list of menu items selected for deletion. I'm confident
 that can get some styling to make it work better, but not from me. :)

 Tested with NVDA/Chrome.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/21603#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform