[wp-trac] [WordPress Trac] #51189: comments_pagination_base missing in get_comment_reply_link() function

WordPress Trac noreply at wordpress.org
Fri May 7 17:52:17 UTC 2021


#51189: comments_pagination_base missing in get_comment_reply_link() function
-------------------------------------------------+-------------------------
 Reporter:  MrPauloEn                            |       Owner:  joedolson
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.8
Component:  Comments                             |     Version:  5.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots needs-testing good-  |     Focuses:
  first-bug has-patch                            |  accessibility
-------------------------------------------------+-------------------------

Comment (by joedolson):

 How to test:
 1) Turn on 'Break comments into pages' at Settings > Discussion
 2) Add comments and set the comments per page to a number that will
 generate at least two pages of comments.
 3) Disable comment-reply.js

 `function test_disable_comment_js(){
     wp_deregister_script( 'comment-reply' );
 }
 add_action( 'init', 'test_disable_comment_js' );`

 4) Go to page 2 of comments on any post with multiple pages of comments.
 5) Click on 'Reply' to a comment on this page.
 6) Click on the commenter's name to return to comment you're replying to.

 Without patch: link points to an anchor on the current page, but the
 comment does not appear on this page.

 With patch: link should point to an anchor on the correct page of
 comments.

 **Note**: this is a case where the link should open in a new tab if the
 user has started writing their comment, as otherwise their comment text
 can be lost.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51189#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list