[wp-trac] [WordPress Trac] #46657: Show site icon in My Sites admin menu

[WordPress Trac]

#46657: Show site icon in My Sites admin menu
-------------------------------------------------+-------------------------
 Reporter:  rmccue                               |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.8
Component:  Networks and Sites                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots needs-
     testing
 * focuses:  css, multisite => multisite


Comment:

 Was reviewing this one and made a few modifications before attaching
 [attachment:"46657.6.diff"].

 1. The patch now makes use of the `has_site_icon()` function instead of
 calling `get_site_icon_url()` directly and needing to store the result in
 a variable.
 1. Switches to using `sprintf()` to populate the image tag.
 1. Added a `srcset` attribute in order to support specifying a 2x image.
 This allows the browser to choose the desired image based on the user's
 pixel density. This pattern is
 [https://core.trac.wordpress.org/browser/branches/5.7/src/wp-
 includes/embed.php#L1203 also used for embed titles for oEmbeds].

 Please test!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46657#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform