[wp-trac] [WordPress Trac] #35725: Add WebP support.

[WordPress Trac]

#35725: Add WebP support.
-------------------------------------------------+-------------------------
 Reporter:  markoheijnen                         |       Owner:
                                                 |  adamsilverstein
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.8
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests needs-dev-note dev-feedback              |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Reopening for some cleanup per comment:177.

 Replying to [comment:177 johnjamesjacoby]:
 > * Should `_wp_get_image_size()` be private? Seems generally useful.
 > * `wp_getimagesize()` was introduced in WordPress 5.7, which competes
 with `_wp_get_image_size()`
 > * Is the `@` in front of the `_wp_get_image_size()` usages necessary?

 Yeah, it seems a bit weird to have two functions with a similar name but a
 slightly different purpose. There is now unnecessary error suppression for
 `_wp_get_image_size()` and missing error suppression for `getimagesize()`,
 which goes against the purpose of [50146] / #49889.


 I think `_wp_get_image_size()` can just be a part of `wp_getimagesize()`
 instead.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35725#comment:178>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform