[wp-trac] [WordPress Trac] #53031: Display counts for available plugin and theme updates on update-core.php

WordPress Trac noreply at wordpress.org
Sun May 2 11:51:55 UTC 2021


#53031: Display counts for available plugin and theme updates on update-core.php
-------------------------------------+-------------------------------------
 Reporter:  sabernhardt              |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  5.8
Component:  Upgrade/Install          |     Version:
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, administration,
  screenshots                        |  ui-copy
-------------------------------------+-------------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:8 audrasjb]:
 > `53031.2.diff` suggests the following changes:
 > - move the whole string into the gettext function so translators are
 able to reverse the order

 Just noting that for RTL translations there is no need to reverse the
 order in cases like this, text direction takes care of that.

 > - use a pluralized translation string so translators are able to use a
 different translation depending on the number of items

 Also noting that this is not as straightforward as it seems, there's a
 note in the plugin i18n handbook:

 > Note that some languages use the singular form for other numbers (e.g.
 21, 31 and so on, much like ’21st’, ’31st’ in English). If you would like
 to special case the singular, check for it specifically:
 > {{{
 > if ( 1 === $count ) {
 >     printf( esc_html__( 'Last thing!', 'my-text-domain' ), $count );
 > } else {
 >     printf( esc_html( _n( '%d thing.', '%d things.', $count, 'my-text-
 domain' ) ), $count );
 > }
 > }}}

 See the discussions in #28502, #33239, #34127, #34307, #34308 for more
 context.

 > - also display the number of translation packages that are going to be
 updated (I'm not 100% sure this one is needed, but… why not)

 No strong objections here, but it looks a bit weird to see the number if
 we're not listing the updates themselves.

 Not listing them was intentional decision at the time, as they are
 generally installed automatically under the hood, e.g. along with a plugin
 or theme update. Related: #28133, #28571, #32270, #34907.

 So going with [attachment:"53031.1.patch"] for now would be my preference
 here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53031#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list