[wp-trac] [WordPress Trac] #52942: Multisite setup problem with Requests_IDNAEncoder

WordPress Trac noreply at wordpress.org
Wed Mar 31 01:16:28 UTC 2021


#52942: Multisite setup problem with Requests_IDNAEncoder
--------------------------+----------------------------------------
 Reporter:  edemir206     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  General       |     Version:  5.7
 Severity:  normal        |  Resolution:  invalid
 Keywords:                |     Focuses:  administration, multisite
--------------------------+----------------------------------------
Changes (by dd32):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 Hi @edemir206,

 Sorry for the issue you're running in here - however the issue lies with
 Elementor, as they're using the functionality incorrectly.

 `Requests_IDNAEncoder::encode()` is intended to encode a hostname only,
 ie. the `example.org` part of `https://example.org/my/site/path/here`, not
 the entire URI - infact using it on the entire URI will result in invalid
 URLs.

 Elementor should a) Not be calling the function in the way they are and b)
 handling error conditions of the function if they must call it incorrectly
 like that.

 [https://github.com/WordPress/Requests Requests] is a separate project
 from WordPress, although bundled with WordPress and now maintained by us.
 While this could be reported to that Github repo, as the function is being
 called incorrectly there's not a lot good that reporting it here will do.

 I'm marking this issue as `invalid`, not because this isn't an issue, but
 that it's an issue that can't be dealt with by WordPress core here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52942#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list