[wp-trac] [WordPress Trac] #52826: New wp_getimagesize() causing unexpected failures

[WordPress Trac]

#52826: New wp_getimagesize() causing unexpected failures
-------------------------------------------------+------------------------
 Reporter:  terriann                             |       Owner:  whyisjake
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.7.1
Component:  Media                                |     Version:  5.7
 Severity:  critical                             |  Resolution:
 Keywords:  has-patch fixed-major needs-testing  |     Focuses:
-------------------------------------------------+------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch has-unit-tests fixed-major dev-feedback => has-patch
     fixed-major needs-testing


Comment:

 Removing `has-unit-tests` as unable to add tests for streams. Why? Getting
 the metadata for Exif requires seeking. The `WP_Test_Stream` currently
 does not support seeking.

 Errors noted:


 {{{
 getimagesize(): stream does not support seeking
 exif_read_data(): stream does not support seeking
 }}}

 For now, manual testing is required to validate the patch.

 Ticket #52922 will extend `WP_Test_Stream` for seeking capability. Once
 completed, then automated tests can be added to both `wp_getimagesize` and
 `wp_read_image_metadata` to valid streams.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52826#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform