[wp-trac] [WordPress Trac] #52914: Inconsistent error message format on login

[WordPress Trac]

#52914: Inconsistent error message format on login
------------------------------------+-----------------------------
 Reporter:  dd32                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)            |      Status:  accepted
 Priority:  normal                  |   Milestone:  5.8
Component:  Login and Registration  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:                          |     Focuses:  ui-copy
------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => accepted
 * milestone:  Awaiting Review => 5.8


Comment:

 Replying to [ticket:52914 dd32]:
 > The formatting is mostly related to [48059] which removed the
 `<strong>Error:</strong>` prefix from a few login related errors, but
 didn't remove it from the authentication handlers and other areas of `wp-
 login.php`. As a result, you can receive two different formats of errors.

 As noted above, [48115] restored any prefixes removed in [48059], so the
 inconsistencies were likely pre-existing.

 Some strings appear to be introduced or adjusted in [2438], [15710],
 [25696], [33019], [33034].

 At a glance, it seems like at least these three strings should get an
 "Error:" prefix:
 * `__( 'Your password reset link appears to be invalid. Please request a
 new link below.' )`
 * `__( 'Your password reset link has expired. Please request a new link
 below.' )`
 * `__( 'The passwords do not match.' )`

 These, on the other hand, seem more like informational messages and
 probably don't need the prefix:
 * `__( 'Your session has expired. Please log in to continue where you left
 off.' ), 'message' );`
 * `__( 'You are now logged out.' ), 'message' );`
 * `__( 'User registration is currently not allowed.' ) );`
 * `__( 'Recovery Mode Initialized. Please log in to continue.' ),
 'message' );`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52914#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform