[wp-trac] [WordPress Trac] #52783: Health Check mis-reports https functionality in certain situations

[WordPress Trac]

#52783: Health Check mis-reports https functionality in certain situations
--------------------------------------+---------------------
 Reporter:  Ipstenu                   |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  5.7.1
Component:  Site Health               |     Version:  5.7
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by peterwilsoncc):

 I've updated the [https://github.com/WordPress/wordpress-develop/pull/1104
 linked pull request] with the following:

 * Remove `! wp_is_https_supported()` branch of health check per
 @TimothyBlynJacobs' suggestion
 * Downgraded failing check to warning
 * (As a maybe) Send basic auth headers in
 `wp_update_https_detection_errors()` if the site is currently been
 accessed behind basic auth.

 I'm a little confused by the code here so feel free to tell me if I have
 it completely incorrect. I'm on leave next week so won't have much of a
 chance to refresh the PR prior to the 5.7.1 RC I am afraid, if I am
 completely missing the mark then please feel free to replace my pull
 request.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52783#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform