[wp-trac] [WordPress Trac] #28569: Calling show_admin_bar( false ) should dehook toolbar entirely

[WordPress Trac]

#28569: Calling show_admin_bar( false ) should dehook toolbar entirely
--------------------------------------+----------------------------
 Reporter:  danielbachhuber           |       Owner:  davidbaumwald
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.8
Component:  Toolbar                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+----------------------------
Changes (by sabernhardt):

 * owner:  chriscct7 => davidbaumwald
 * milestone:   => 5.8


Comment:

 The patch still applies, though it could use a
 [https://developer.wordpress.org/coding-standards/wordpress-coding-
 standards/php/#yoda-conditions Yoda condition] on the check.

 Also, it would help if someone with deeper knowledge of the admin bar (and
 themes) agrees this is the correct way to do this. I have used the
 `show_admin_bar` filter before, and returning false with that removes the
 style tag. But I have not used `show_admin_bar( false )` to know how that
 works.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/28569#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform