[wp-trac] [WordPress Trac] #52826: New wp_getimagesize() causing unexpected failures
WordPress Trac
noreply at wordpress.org
Thu Mar 25 03:58:32 UTC 2021
#52826: New wp_getimagesize() causing unexpected failures
--------------------------------------+------------------------
Reporter: terriann | Owner: whyisjake
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.7.1
Component: Media | Version: 5.7
Severity: critical | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+------------------------
Comment (by peterwilsoncc):
I tried adding some unit tests in the [https://github.com/WordPress
/wordpress-develop/pull/1121/checks linked pull request] but either:
* I am doing something wrong with `WP_Test_Stream` within the test suite
(likely), or,
* `WP_Test_Stream` is super basic and doesn't support exif data (which
seems unlikely)
If someone could drop some pointers on the PR, that would be most helpful
--
Also, I think the `$info` definition that is removed in
[attachment:"52826.5.diff"] is still required so I've added that back in
to the linked pull request, otherwise the functional code is identical to
@terriann's
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52826#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list