[wp-trac] [WordPress Trac] #52826: New wp_getimagesize() causing unexpected failures

WordPress Trac noreply at wordpress.org
Mon Mar 22 22:06:15 UTC 2021


#52826: New wp_getimagesize() causing unexpected failures
-------------------------------------+------------------------
 Reporter:  terriann                 |       Owner:  whyisjake
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.7.1
Component:  Media                    |     Version:  5.7
 Severity:  critical                 |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+------------------------

Comment (by azaozz):

 Replying to [comment:14 RogerTheriault]:
 > To match the signature, and the intent of the existing calls, the
 wrapper here will need to conditionally call with one or two parameters,
 as in attachment:trac-52826.diff

 Right, thinking trac-52826.diff looks better and is easier to
 read/understand imho. It would also remove the confusing/hard-to-read
 `array &$image_info = null` (which reads something like "by default the
 optional array $imageinfo is not an array").

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52826#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list