[wp-trac] [WordPress Trac] #52843: Remove explicit puppeteer dependency from package.json
WordPress Trac
noreply at wordpress.org
Fri Mar 19 03:20:27 UTC 2021
#52843: Remove explicit puppeteer dependency from package.json
--------------------------------------+-----------------------
Reporter: isabel_brison | Owner: desrosj
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.8
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------
Comment (by isabel_brison):
@desroj, did you regenerate the the package-lock before committing? I
notice that your commit just removes the root puppeteer dependency on line
18646, but the package-lock diff in my PR shows it instead to be replaced
by the updated version: https://github.com/WordPress/wordpress-
develop/pull/1102/files#diff-
053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519L18646,
and the nested dependency of wp-scripts being removed:
https://github.com/WordPress/wordpress-develop/pull/1102/files#diff-
053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519L3915
I only got it to work locally after deleting my `node_modules` and re-
installing, so you may have to do that too. In any case, to avoid errors
it's better to commit the whole package-lock changeset.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52843#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list