[wp-trac] [WordPress Trac] #52826: New wp_getimagesize() causing unexpected failures

[WordPress Trac]

#52826: New wp_getimagesize() causing unexpected failures
------------------------------------------+------------------------
 Reporter:  terriann                      |       Owner:  whyisjake
     Type:  defect (bug)                  |      Status:  closed
 Priority:  normal                        |   Milestone:  5.7.1
Component:  Media                         |     Version:  5.7
 Severity:  critical                      |  Resolution:  fixed
 Keywords:  has-patch commit fixed-major  |     Focuses:
------------------------------------------+------------------------
Changes (by peterwilsoncc):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50553" 50553]:
 {{{
 #!CommitTicketReference repository="" revision="50553"
 Media: Pass the appropriate reference into `wp_getimagesize`.

 With changes that were introduced in #49889 the second parameter for
 getimagesize() function is expecting a a reference.

 Previously, most calls did not pass the 2nd param, and as a result, we are
 getting unexpected results.

 This was only a problem with applications that are using a custom stream
 wrapper, and the image contained EXIF data.

 For more see:

     https://github.com/humanmade/S3-Uploads/issues/496
     https://github.com/aws/aws-sdk-php/issues/1923

 Fixes #52826.
 Merges [50552] to the 5.7 branch.
 Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev,
 whyisjake.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52826#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform