[wp-trac] [WordPress Trac] #52843: Remove explicit puppeteer dependency from package.json
WordPress Trac
noreply at wordpress.org
Thu Mar 18 05:05:03 UTC 2021
#52843: Remove explicit puppeteer dependency from package.json
------------------------------+-----------------------------
Reporter: isabel_brison | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version:
Severity: normal | Keywords:
Focuses: |
------------------------------+-----------------------------
The explicit dependency was added here: https://github.com/WordPress
/wordpress-develop/pull/347/files because puppeteer wasn't being properly
installed as a dependency of the @wordpress/scripts package.
In the meantime, the version in package.json has fallen out of sync with
@wordpress/scripts, so I tried removing it. After deleting node_modules
and the lock file, and reinstalling everything, the tests are running
without errors.
It's easier for maintainability if we don't have to update versions in two
different places, so I propose removing puppeteer from package.json
altogether.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52843>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list