[wp-trac] [WordPress Trac] #45785: Update Underscore to the latest version

WordPress Trac noreply at wordpress.org
Tue Mar 16 16:25:20 UTC 2021

#45785: Update Underscore to the latest version
 Reporter:  mukesh27                       |       Owner:  (none)
     Type:  enhancement                    |      Status:  assigned
 Priority:  normal                         |   Milestone:  5.8
Component:  External Libraries             |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  early needs-testing has-patch  |     Focuses:
Changes (by SergeyBiryukov):

 * keywords:  early needs-testing needs-patch => early needs-testing has-


 [attachment:"45785.3.diff"] is an initial refreshed patch that updates
 Underscore to
 [https://github.com/jashkenas/underscore/releases/tag/1.13.0-1 version
 1.13.0-1] and seems to work, but causes a failure in the `verify:source-
 maps` task during the build process (see [44740] / #46218 for more
 Running "verify:source-maps" task
 Warning: The build/wp-includes/js/underscore.js file must not contain a
 sourceMappingURL. Use --force to continue.

 [attachment:"45785.4.diff"] fixes that by adding a new build task to
 remove the `sourceMappingURL` reference, though perhaps we'd want to make
 it more generic for future use, and not specific to `underscore.js`.

 All tests seem to pass with [attachment:"45785.4.diff"].

 List of changes in Underscore:

Ticket URL: <https://core.trac.wordpress.org/ticket/45785#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list