[wp-trac] [WordPress Trac] #52758: 5.7 About Page: Image comparison doesn't work on first load on some browsers

[WordPress Trac]

#52758: 5.7 About Page: Image comparison doesn't work on first load on some
browsers
--------------------------+-------------------------
 Reporter:  vladytimy     |       Owner:  ryelle
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  5.7.1
Component:  Help/About    |     Version:  5.7
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------
Changes (by ryelle):

 * owner:  (none) => ryelle
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50535" 50535]:
 {{{
 #!CommitTicketReference repository="" revision="50535"
 Help/About: Run image comparison script after all assets have loaded.

 If the callback is called before the images are loaded, the comparison
 doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not
 guarantee that the images are loaded. This switches to use the `load`
 event, which waits for all resources to load.

 Props vladytimy, joyously, sergeybiryukov.
 Fixes #52758.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52758#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform