[wp-trac] [WordPress Trac] #52321: Add site icon to rest index
WordPress Trac
noreply at wordpress.org
Fri Mar 12 20:20:06 UTC 2021
#52321: Add site icon to rest index
-------------------------------------------------+-------------------------
Reporter: spacedmonkey | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Future
| Release
Component: REST API | Version: 4.4
Severity: normal | Resolution:
Keywords: good-first-bug has-patch needs- | Focuses:
unit-tests |
-------------------------------------------------+-------------------------
Changes (by spacedmonkey):
* keywords: needs-patch good-first-bug => good-first-bug has-patch needs-
unit-tests
Comment:
Thanks for the patch @palmiak.
Looking at the patch, it seems like we should add some basic unit tests.
Maybe a case with and without a site icon set to see what happens. The
tests should be added [https://github.com/WordPress/wordpress-
develop/blob/43443bdf1529883e9a39071b86556c15a431786e/tests/phpunit/tests
/rest-api/rest-server.php#L933 here].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52321#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list