[wp-trac] [WordPress Trac] #50824: Allow for WordPress.org to remotely disable auto-updates for plugins/themes

WordPress Trac noreply at wordpress.org
Fri Mar 12 14:49:48 UTC 2021


#50824: Allow for WordPress.org to remotely disable auto-updates for plugins/themes
-------------------------------------------+------------------------
 Reporter:  dd32                           |       Owner:  whyisjake
     Type:  enhancement                    |      Status:  closed
 Priority:  normal                         |   Milestone:  5.5
Component:  Upgrade/Install                |     Version:  5.5
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed  |     Focuses:
-------------------------------------------+------------------------

Comment (by TimothyBlynJacobs):

 I might be missing something, but it seems like this code does the
 opposite. If `disable_autoupdate` is set to `true`, then it forces the
 update to be enabled. The code should read as.

 {{{#!php
         // If the `disable_autoupdate` flag is set, override any user-
 choice, but allow filters.
        if ( ! empty( $item->disable_autoupdate ) ) {
                     $update = ! $item->disable_autoupdate;
         }
 }}}

 Notice the negation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50824#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list