[wp-trac] [WordPress Trac] #37012: Remove non hierarchical test for sticky in post table hidden fields
WordPress Trac
noreply at wordpress.org
Tue Mar 9 06:38:49 UTC 2021
#37012: Remove non hierarchical test for sticky in post table hidden fields
-------------------------------+-----------------------------
Reporter: nicolasrenard | Owner: (none)
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Posts, Post Types | Version: 4.6
Severity: normal | Resolution: duplicate
Keywords: | Focuses: administration
-------------------------------+-----------------------------
Changes (by SergeyBiryukov):
* focuses: => administration
* component: Administration => Posts, Post Types
Comment:
Replying to [comment:2 peterwilsoncc]:
> Since your report, the condition has changed to display the sticky posts
option only on the posts screen.
>
> This was done in commit [16680] for ticket #12702.
Just noting that [16680], while related, does not seem to affect this
particular report, as that commit was done 10 years ago, and this ticket
is from 5 years ago. That commit did not touch the `get_inline_data()`
function: the line that the patch removes is [source:tags/5.6.2/src/wp-
admin/includes/template.php?marks=371#L358 still there as of WordPress
5.6.2].
We might want to replace the `! $post_type_object->hierarchical` condition
with `'post' === $post->post_type`, for consistency with the similar
checks in [16680].
If anyone thinks this is worth investigating further, feel free to reopen.
That said, #12702 would still be a better place to continue the discussion
about "sticky" feature support for custom post types.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37012#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list