[wp-trac] [WordPress Trac] #34564: WP_List_Table::get_column_info() inefficient

[WordPress Trac]

#34564: WP_List_Table::get_column_info() inefficient
------------------------------------------+--------------------------
 Reporter:  bobbingwide                   |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  5.8
Component:  Administration                |     Version:  4.3
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:  performance
------------------------------------------+--------------------------
Changes (by mikeschroder):

 * keywords:   => needs-patch needs-unit-tests
 * focuses:   => performance
 * milestone:   => 5.8


Comment:

 Hi @bobbingwide!

 Sorry it's taken so long for a response.
 This was talked about
 [https://wordpress.slack.com/archives/C02RQBWTW/p1615266276008100 in
 today's triage].

 It looks like "horse reasons" basically means "arbitrary reasons" or
 "unknown reasons" in this particular case, given
 [https://core.trac.wordpress.org/changeset/32722 the commit message]. As
 this was also confusing to some other folks in the chat, that'd probably
 make sense to change.

 @peterwilsoncc suggested that a next step would be looking into whether
 `get_primary_column_name()` can be cached, either as a property of the
 class or as a static variable in the function, and suggested 5.8 as a
 milestone for consideration.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34564#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform