[wp-trac] [WordPress Trac] #52721: No way to filter value of $credentials['remember'] in wp_signon

[WordPress Trac]

#52721: No way to filter value of $credentials['remember'] in wp_signon
------------------------------------+---------------------
 Reporter:  mirkolofio              |       Owner:  (none)
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  5.8
Component:  Login and Registration  |     Version:  1.5.1
 Severity:  normal                  |  Resolution:
 Keywords:  needs-patch             |     Focuses:
------------------------------------+---------------------
Changes (by peterwilsoncc):

 * version:  5.6.2 => 1.5.1
 * milestone:  Awaiting Review => 5.8


Comment:

 Hi @mirkolofio and welcome back to trac.

 It looks like the `@todo` asking whether the filter should be deprecated
 was added in early 2014 as part of [27353].

 I think allowing the `remember me` setting to be filtered makes sense,
 both for the use case you describe and for plugins either wishing to
 enforce or prevent users from being remembered.

 My inclination is to deprecate the action and replace it with a filter
 (`wp_signon_credentials` maybe) that will allow plugin authors to modify
 the credentials array how they see fit.

 A search of the plugin repository shows
 [https://wpdirectory.net/search/01F0AHF01TWCPF93YQYG42TGA6 374 plugins are
 using the current action], the top five all have over one million
 installs, the top two over three million.

 I'll move this on to the 5.8 milestone to start the discussion:
 * naming things
 * whether to deprecate the existing action (my inclination) or simply
 delete the todo.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52721#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform