[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------+-----------------------
 Reporter:  pbiron             |       Owner:  pbiron
     Type:  enhancement        |      Status:  reopened
 Priority:  normal             |   Milestone:  5.8
Component:  Upgrade/Install    |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  early needs-patch  |     Focuses:
-------------------------------+-----------------------

Comment (by KZeni):

 @pbiron Gotcha. I was just hoping for this since, in my recent case, the
 Simple History plugin had a syntax error in a recent release where it took
 down all sites using it for me per the sites being set to auto-update. The
 other case was the hCaptcha for WordPress plugin where they left in
 development code where it was trying to require a file that didn't exist.

 Both cases were involving a very straightforward & immediate server error
 simply by way of simply having errors when active without any further
 action needed (errors in the code itself), and WordPress (running 5.6.2)
 simply applied the update & had things break site-wide as a result.

 Meanwhile, it seems like the kind of situation that the error-checking
 upon attempting to activate a plugin that'd cause a server error would
 prevent, but then that protection isn't happening on update & is only on
 activation.

 I guess I was hoping that type of error prevention could be inserted
 during the update process as well somehow while I was uncertain if this
 particular ticket would take care of that situation, it'd be possible to
 expand this ticket to include that scenario, and/or this ticket is using a
 different mechanism from that where it'd be a wholly separate
 request/implementation (with it sounding like the latter, currently.)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:78>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform