[wp-trac] [WordPress Trac] #52730: Mixed content error with RSS widget

[WordPress Trac]

#52730: Mixed content error with RSS widget
--------------------------+------------------------------
 Reporter:  gregmagn1     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Widgets       |     Version:  5.6.2
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui
--------------------------+------------------------------

Comment (by sabernhardt):

 @gregmagn1 Thanks for the report!

 If your WordPress Address ([https://wordpress.org/support/article
 /changing-the-site-url/ Site URL]) setting uses "https" then I don't think
 the icon should be served insecurely (unless a plugin filters
 `includes_url`).

 However, this might be a good situation for using the `includes_url`
 function's "relative" argument in
 [https://core.trac.wordpress.org/browser/tags/5.6/src/wp-includes/widgets
 /class-wp-widget-rss.php#L88 class-wp-widget-rss.php]:
 {{{
 $icon = includes_url( 'images/rss.png', 'relative' );
 }}}

 If forcing secure, it could be more like this:
 {{{
 $scheme = is_ssl() ? 'https' : null;
 $icon   = includes_url( 'images/rss.png', $scheme );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52730#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform