[wp-trac] [WordPress Trac] #52713: Reverse logic in wp_robots function and filter

[WordPress Trac]

#52713: Reverse logic in wp_robots function and filter
--------------------------+-----------------------
 Reporter:  Cybr          |       Owner:  flixos90
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.7.1
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------
Changes (by flixos90):

 * keywords:   => needs-patch
 * owner:  (none) => flixos90
 * status:  new => assigned


Comment:

 @Cybr @peterwilsoncc I agree the implementation here is flawed, the ticket
 raises valid points.

 > Perhaps it would be best to remove the "Don't allow mutually exclusive
 directives"-block entirely.

 I think this suggestion makes most sense. Adding specific precedences and
 directives here increases the maintenance burden for little benefit, and I
 also agree with the assessment that it might (unintentionally) be
 interpreted as some kind of guidance.

 So I'm leaning towards removing this block entirely and leaving
 responsibility to the individual filter callbacks, since it is infeasible
 to centrally control that completely anyway.

 > I don't think it's a blocker for release so putting this on to the 5.7.1
 milestone for now.

 Agreed, while it's worth fixing, it is not critical. Let's fix it for
 5.7.1.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52713#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform