[wp-trac] [WordPress Trac] #52484: The wp_update_https_detection_errors function may fail to update option values.

WordPress Trac noreply at wordpress.org
Mon Mar 1 21:15:40 UTC 2021


#52484: The wp_update_https_detection_errors function may fail to update option
values.
-------------------------------------------------+-------------------------
 Reporter:  tmatsuur                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.7
Component:  Security                             |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  reviewed i18n-change                           |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch has-unit-tests dev-feedback => has-patch has-unit-
     tests dev-reviewed i18n-change
 * milestone:  5.7.1 => 5.7


Comment:

 Replying to [comment:10 flixos90]:
 > Or, since we don't use the real message anyway, simply always use "HTTP
 request failed." instead of the exception message.

 Makes sense to me, let's go with this for 5.7. Thanks for the PR!

 We could add more information to this message later, though perhaps that
 would be something for Site Health and not for this particular function.

 Marking as `i18n-change` due to two new strings.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52484#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list