[wp-trac] [WordPress Trac] #53403: Query block: Notice thrown if template includes post content.
WordPress Trac
noreply at wordpress.org
Tue Jun 29 19:59:45 UTC 2021
#53403: Query block: Notice thrown if template includes post content.
-----------------------------+---------------------
Reporter: peterwilsoncc | Owner: (none)
Type: defect (bug) | Status: new
Priority: highest omg bbq | Milestone: 5.8
Component: Editor | Version: trunk
Severity: blocker | Resolution:
Keywords: needs-testing | Focuses:
-----------------------------+---------------------
Changes (by desrosj):
* keywords: => needs-testing
Old description:
> Including the post content block within a query block will cause a notice
> to be thrown both within the block editor and when the post containing
> the query block is viewed on the front end.
>
> The notice is approximately 100K per post (so 500K with five posts, etc).
>
> Steps to reproduce from a fresh install of WP trunk.
>
> 1. Enable debug mode with logging:
> {{{
> define( 'WP_DEBUG', true );
> define( 'WP_DEBUG_LOG', true );
> define( 'WP_DEBUG_DISPLAY', false );
> define( 'SCRIPT_DEBUG', true );
> }}}
> 1. Create a new post
> 1. Insert a query block (simple list view with title and excerpt)
> 1. Edit the query block template
> 1. Add a post content block to the template
> 1. Save post as draft
> 1. Observe notice in `wp-content/debug.log`.
> 1. Publish post (this will trigger another notice)
> 1. View post on the front end of the site (this will trigger another
> notice)
> 1. Change debug settings to display errors: `define( 'WP_DEBUG_DISPLAY',
> true );`
> 1. Reload page.
> 1. Observe notice on screen
>
> If I can figure out when this was introduced, I'll post a follow up
> comment.
>
> --
>
> Due to the size of the notice, I have called this a blocker. I pretty
> quickly racked up a 17MB log of errors on one of my trunk installs.
>
> I've created a ticket upstream
> ([https://github.com/WordPress/gutenberg/issues/32681 Gutenberg#32681])
> but opening this here as it blocks the release due to the size of the
> error logged.
New description:
== Including the post content block within a query block will cause a
notice to be thrown both within the block editor and when the post
containing the query block is viewed on the front end.
The notice is approximately 100K per post (so 500K with five posts, etc).
Steps to reproduce from a fresh install of WP trunk.
1. Enable debug mode with logging:
{{{
define( 'WP_DEBUG', true );
define( 'WP_DEBUG_LOG', true );
define( 'WP_DEBUG_DISPLAY', false );
define( 'SCRIPT_DEBUG', true );
}}}
1. Create a new post
1. Insert a query block (simple list view with title and excerpt)
1. Edit the query block template
1. Add a post content block to the template
1. Save post as draft
1. Observe notice in `wp-content/debug.log`.
1. Publish post (this will trigger another notice)
1. View post on the front end of the site (this will trigger another
notice)
1. Change debug settings to display errors: `define( 'WP_DEBUG_DISPLAY',
true );`
1. Reload page.
1. Observe notice on screen
If I can figure out when this was introduced, I'll post a follow up
comment.
--
Due to the size of the notice, I have called this a blocker. I pretty
quickly racked up a 17MB log of errors on one of my trunk installs.
I've created a ticket upstream
([https://github.com/WordPress/gutenberg/issues/32681 Gutenberg#32681])
but opening this here as it blocks the release due to the size of the
error logged.
--
Comment:
Unless the pull request is updated in the next few hours, it looks like
this one will miss RC1. However, I still feel that this is a blocker for
5.8, so I'm going to leave it for now and it can be added prior to RC2.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53403#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list