[wp-trac] [WordPress Trac] #40275: Use a monospace-type font to display passwords

[WordPress Trac]

#40275: Use a monospace-type font to display passwords
----------------------------------------+-----------------------
 Reporter:  robdxw                      |       Owner:  ryelle
     Type:  enhancement                 |      Status:  reopened
 Priority:  normal                      |   Milestone:  5.8
Component:  Users                       |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  ui, css
----------------------------------------+-----------------------
Changes (by pixolin):

 * keywords:  good-first-bug has-patch => good-first-bug needs-patch
 * status:  closed => reopened
 * version:   => trunk
 * resolution:  fixed =>


Comment:

 While I agree, formatting the password input field with a monospace font
 makes it by far more readable, I believe it would be easier to add the
 existing class `code` to the input-field in file
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/user-new.php
 (line 637)
 {{{#!php
 <input type="password" name="pass1" id="pass1" class="regular-text code"
 value="" autocomplete="off" data-pw="<?php echo esc_attr(
 wp_generate_password( 24 ) ); ?>" aria-describedby="pass-strength-result"
 />
 }}}

 and in https://core.trac.wordpress.org/browser/trunk/src/wp-admin/user-
 edit.php (line 567):
 {{{#!php
 <input type="password" name="pass1" id="pass1" class="regular-text code"
 autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr(
 $initial_password ); ?>" aria-describedby="pass-strength-result" />
 }}}


 The class `.code` was already defined in file
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/install.css
 (line 53).

 Certainly not a big difference, but redeclaring a css rule seems redundant
 to me.

 (Sorry for not providing a patch. Haven't done that since ages and feel
 somewhat clueless if it comes to SVN.)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40275#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform