[wp-trac] [WordPress Trac] #53512: Twenty Seventeen: JS errors when displaying legacy widgets

WordPress Trac noreply at wordpress.org
Tue Jun 29 12:56:56 UTC 2021


#53512: Twenty Seventeen: JS errors when displaying legacy widgets
------------------------------+-----------------------------
 Reporter:  Boniu91           |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.8
Component:  Bundled Theme     |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"51257" 51257]:
 {{{
 #!CommitTicketReference repository="" revision="51257"
 Twenty Seventeen: Avoid JS errors when displaying legacy widgets.

 Make sure the `$sidebar` variable is defined and has at least one entry in
 the array, before adding the `.below-entry-meta` class to elements below
 the entry meta.

 Previously, the theme expected sidebar markup to exist on the page if
 sidebars are defined, but that markup is missing since only the widget
 itself and headers/footers of the page are loaded in the iframe used to
 display legacy widgets (widgets added prior to WordPress 5.8).

 Props Clorith, Boniu91, desrosj.
 Fixes #53512.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53512#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list