[wp-trac] [WordPress Trac] #53535: Site health/i18n: add a separator between tab names and "Site health"

WordPress Trac noreply at wordpress.org
Mon Jun 28 08:31:44 UTC 2021


#53535: Site health/i18n: add a separator between tab names and "Site health"
-------------------------------------+------------------------------
 Reporter:  audrasjb                 |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Site Health              |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch i18n-change  |     Focuses:
-------------------------------------+------------------------------

Comment (by swissspidy):

 Unrelated, but shouldn't the `isset()` check there really be `isset(
 $_GET['tab'], $tabs[ $_GET['tab'] )`? Otherwise there would be "Undefined
 array key" notices/warnings when using something like
 `?tab=thisdoesnotexist`.

 Related to that, the "Status" tab is not marked as active (blue border
 below the tab) when just visiting the `site-health.php` site. Clicking on
 "Status" links to `site-health.php?tab`, making it active.

 Tested using 5.8-beta4-51247

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53535#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list